Skip to content

Fix array initialization with array holes #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

rerobika
Copy link
Member

@rerobika rerobika commented Sep 6, 2019

Fast mode access arrays must be converted back to normal if the array hole count reaches the limit during the initializtaion.
This patch fixes #3075.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

Fast mode access arrays must be converted back to normal if the array hole count reaches the limit during the initializtaion.
This patch fixes jerryscript-project#3075.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
@rerobika rerobika added bug Undesired behaviour ecma core Related to core ECMA functionality labels Sep 6, 2019
@rerobika rerobika requested a review from dbatyai September 6, 2019 07:23
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rerobika rerobika merged commit c79659d into jerryscript-project:master Sep 9, 2019
@rerobika rerobika deleted the fix_issue_3075 branch June 16, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour ecma core Related to core ECMA functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion ext_obj_p->u.array.hole_count <= ECMA_FAST_ARRAY_MAX_HOLE_COUNT in ecma_fast_array_set_property
3 participants